SSH audit events and contexts #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
reviewed
Jun 27, 2023
ueno
reviewed
Jun 28, 2023
ueno
approved these changes
Jun 28, 2023
Jakuje
reviewed
Jun 28, 2023
Jakuje
reviewed
Jun 28, 2023
docs/logging-format.md
Outdated
|
|
||
| - `ssh::handshake_client` | ||
| - `ssh::ident_string` = `SSH-2.0-OpenSSH_8.8` | ||
| - `ssh::client key` |
There was a problem hiding this comment.
underscore instead of space
Suggested change
| - `ssh::client key` | |
| - `ssh::client_key` |
I assume the events should come in order they happen during the ssh session so the client key operation should happen only after the key_exchange is finished.
The hostkey verification happens as part of the key exchange though so it is a question whether it should be part of that context or somehow separately.
In any case, this is a context so it should have again some events attached for example:
Suggested change
| - `ssh::client key` | |
| - `ssh::client_key` | |
| - `ssh::key_algorithm` = `rsa-sha2-256` | |
| - `ssh::rsa_bits` = `2048` |
|
Updated description and full context example is pushed |
Jakuje
reviewed
Jun 29, 2023
Jakuje
approved these changes
Jun 29, 2023
|
Thank you both, it seems the document is in a really good shape now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23